paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-23 07:52:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
40,506 Commits 30 Branches 160 Tags
f4f37fca146c61c7365e986bdaf6ea028e6ffda5
Commit Graph

7360 Commits

Author SHA1 Message Date
Vishnu KS
2ae70ff76c i18n: Translate who reacted tooltip message. 2020-10-29 16:50:01 -07:00
Harsh Sharma
966bbf6b3d right_sidebar: Change keyboard help tooltip to float left. 
Floating upwards caused a weird flickering effect if the mouse floated
onto the tooltip's body, and it's still reasonable UI floating left
(and also there's guaranteed to be space).

Fixes #16438.
 2020-10-29 16:17:33 -07:00
sahil839
8d783e9d46 streams: Show error when trying to make a default stream private. 
We show failure message in stream privacy modal when user tries to
set a default stream as private.
 2020-10-29 15:47:34 -07:00
sahil839
1477416515 stream_data: Exclude private streams from get_non_default_stream_names. 
We do not show private streams in default streams typeahead as we do
not allow to set private stream as default.
 2020-10-29 15:47:34 -07:00
ryanreh99
b38cbc8f34 typeahead: Fix stream+topic completions for empty query. 
This fixes a bug where the autocomplete for topics
deleted all the text content, if the topic jump is used
without entering any text.

The topic typeahead is automatically set up, on entering
the ">" key for stream completions. Therefore there is a
case where the user can select a typeahead item without
entering any text.

Thus the token length will be 0 and `beginning.slice(0, -0)` returns
"" instead of the `beginning` string.  The case is only relevant for
"topic_list" completion as we don't set up the typeahead for empty
strings.

Fix this by reverting a hunk of
48f5e5179a, adding a test.

Fixes #16599.

Co-authored-by: Rohitt Vashishtha <aero31aero@gmail.com>
 2020-10-29 11:02:17 -07:00
Greg Rowe
d1ae0cff1e video_calls: Refactor zoom_xhrs to support other OAuth video applications. 
Rename zoom_xhrs to video_call_xhrs.
Rename abort_zoom to abort_video_callbacks.
Delete callbacks from video_call_xhrs when they have been aborted.
Move generation of video_call_id in the .videolink handler into
the Jitsi video call handling block as it is the only place it is
referenced.
 2020-10-28 23:08:16 -07:00
Anders Kaseorg
954ad9f7ab favicon: Invalidate favicon_state.image without a network request. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-28 23:06:26 -07:00
Vishnu KS
358b4f6438 apps: Link android download button directly to APK file. 2020-10-28 23:04:14 -07:00
Vishnu KS
fdea49742c apps: Use GitHub API for generating the web app download link. 2020-10-28 23:04:14 -07:00
Anders Kaseorg
72d6ff3c3b docs: Fix more capitalization issues. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-23 11:46:55 -07:00
sahil839
465122b0df compose: Show error for wildcard messages according to settings. 
This commit changes UI to show /error for sending message with
wildcard mention according to wildcard mention policy of organization.

Fixes #16211.
 2020-10-22 15:00:27 -07:00
sahil839
1d5aa2e514 settings_org: Add frontend to change wildcard_mention_policy. 
We add dropdown for wildcard_mention_policy in organization
permissions page.
 2020-10-22 15:00:27 -07:00
Anders Kaseorg
55146aaa1a favicon: Close race condition in Chrome bug workaround. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-22 11:24:57 -07:00
Steve Howell
7ff3859136 subscriber events: Change schema for peer_add/peer_remove. 
We now can send an implied matrix of user/stream tuples
for peer_add and peer_remove events.

The client code basically does this:

    for stream_id in event['stream_ids']:
        for user_id in event['user_ids']:
            update_sub(stream_id, user_id)

We used to send individual events, which gets real
expensive when you are creating new streams. For
the case of copy-to-stream case, we should see
events go from U to 1, where U is the number of users
added.

Note that we don't yet fully optimize the potential
of this schema.  For adding a new user with lots
of default streams, we still send S peer_add events.

And if you subscribe a bunch of users to a bunch of
private streams, we only go from U * S to S; we can't
optimize it down to one event easily.
 2020-10-22 11:19:53 -07:00
Anders Kaseorg
5c6202ca97 notifications: Use a dynamic SVG favicon for unread counts. 
Closes #2304.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-21 07:43:00 -07:00
Aryan Shridhar
621bef5958 shortcuts: Fixed Keyboard shortcut in Firefox. 
In Firefox, other Keyboard shortcuts stop working once the users
presses escape to exit the search bar.

Fix this by explicitly focusing the main panel after we exit search.

Fixes #16394.
 2020-10-20 17:07:48 -07:00
YashRE42
7ee3484b7b portico-styles: Rename to portico_styles.css. 2020-10-19 11:50:39 -07:00
YashRE42
51f82ad839 right_sidebar: Rename .css file to right_sidebar.css. 
This changes the file name to existing conventions, it does not,
however, change the actual `.right_sidebar` tag used in the
app.
 2020-10-18 14:09:47 -07:00
YashRE42
bd72ba76f3 left-sidebar: Rename .css file to left_sidebar.css. 
This changes the file name to existing conventions, it does not,
however, change the actual `.left_sidebar` tag used in the
app.
 2020-10-18 14:09:47 -07:00
YashRE42
46a74d3e08 informational-overlays: Rename .css file to informational_overlays. 
This changes the file name to existing conventions, it does not,
however, change the actual `.informational-overlay` tag used in the
app.
 2020-10-18 14:09:47 -07:00
YashRE42
178e0b7d47 navbar: Use location.href instead of location.replace. 
As per https://stackoverflow.com/questions/1865837/ location.href
should be preferred to location.replace in some places due to the
fact that location.replace violates browser history and breaks back key.
 2020-10-18 14:05:45 -07:00
Aman Agrawal
fbf7cb82a7 web_public_guest: Rename to web_public_visitor for clarity. 
Using web_public_guest for anonymous users is confusing since
'guest' is actually a logged-in user compared to
web_public_guest which is not logged-in and has only
read access to messages. So, we rename it to
web_public_visitor.
 2020-10-13 16:59:52 -07:00
Anders Kaseorg
dd48dbd912 docs: Add spaces to “check out”, “log in”, “set up”, “sign up” as verbs. 
“Checkout”, “login”, “setup”, and “signup” are nouns, not verbs.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-13 15:47:13 -07:00
ryanreh99
111ba564ae popover: Show normal popover for the stream_subscription_info users. 
This shows the normal popover instead of extended profile.
We use the standard event handler attached to the body element in
`popovers.js` instead of attaching a new one.
 2020-10-12 17:42:52 -07:00
Aman Agrawal
623fb63406 recent_topics: Go to topic if user clicks anywhere in topic col. 2020-10-08 17:05:06 -07:00
Aman Agrawal
d3f4f64b0e timerender: Extract func to calculate days_old from time. 2020-10-08 17:05:06 -07:00
Aman Agrawal
8b419c93e4 message_send: Fix old guests being treated as full members. 
For streams in which only full members are allowed to post,
we block guest users from posting there.

Guests users were blocked from posting to admin only streams
already. So now, guest users can only post to
STREAM_POST_POLICY_EVERYONE streams.

This is not a new feature but a bugfix which should have
happened when implementing full member stream policy / guest users.
 2020-10-08 11:30:11 -07:00
Anders Kaseorg
81d21068b5 eslint: Fix no-useless-concat. 
https://eslint.org/docs/rules/no-useless-concat

And add some escaping to static/js/markdown.js while I’m here.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
5c8117a426 eslint: Fix no-implicit-coercion. 
https://eslint.org/docs/rules/no-implicit-coercion

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
0042cf51c1 eslint: Fix unicorn/better-regex. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/better-regex.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
65f86274b2 eslint: Fix unicorn/prefer-dataset. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-dataset.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
e68595a3fc eslint: Fix unicorn/no-reduce. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-reduce.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
62dfee4930 eslint: Fix unicorn/prefer-node-append and unicorn/prefer-node-remove. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-node-append.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-node-remove.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
8098acb63c eslint: Fix unicorn/prefer-trim-start-end. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-trim-start-end.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
78ccb15d9e eslint: Fix unicorn/no-zero-fractions. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-zero-fractions.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
0d4af4f8e7 eslint: Fix unicorn/prefer-type-error. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-type-error.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
e0b1daa96d eslint: Fix unicorn/prefer-add-event-listener. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
2694f5caed eslint: Fix unicorn/prefer-array-find. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-array-find.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
72cc78dfa3 js: Optimize out unnecessary jQuery filter calls. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
fd11c9c666 eslint: Fix unicorn/prefer-includes. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-includes.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
b178fc6069 eslint: Fix unicorn/prefer-set-has. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-set-has.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
de791b82b6 eslint: Fix unicorn/no-for-loop. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-for-loop.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
73a14bee6f eslint: Fix unicorn/escape-case and unicorn/no-hex-escape. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/escape-case.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-hex-escape.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
f92224c744 eslint: Fix unicorn/catch-error-name. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/catch-error-name.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
d654992164 eslint: Fix unicorn/prefer-optional-catch-binding. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-optional-catch-binding.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
70a0260ac1 eslint: Fix unicorn/prefer-text-content. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-text-content.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
bd05f1c9f8 eslint: Fix unicorn/prefer-query-selector. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-query-selector.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
c7cbdba257 eslint: Fix unicorn/{new-for-builtins,throw-new-error,error-message}. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/new-for-builtins.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/throw-new-error.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/error-message.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
48f5e5179a eslint: Fix unicorn/prefer-string-slice. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-string-slice.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg
fb233bd994 eslint: Fix unicorn/prefer-number-properties. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md

MDN says these were added to Number for modularization of globals.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00