The result message shown when adding members to a stream
previously listed the name of every member being added,
which could be noisy for large groups.
This commit updates stream_subscription_request_result.hbs to
conditionally display clearer, more concise messages based
on the number of subscribed and already subscribed users.
This improves readability and user experience when handling
large subscription actions.
Fixes part of #34347
Co-authored-by: Rajeev Tapadia <108951750+rajeevtapadia@users.noreply.github.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Adds a loading spinner for both `Unsubscribe` and `Remove`
buttons in channel and group settings.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
The data conversion logic for exports from other apps will try to set
these announcement channels based on presence of channels with an
appropriate default name - however those sometimes do not exist.
Then it falls on the import process to choose a good default value. That
default should be the channel with the most subscribers.
This requires a tweak to the send_zulip_update_announcements_to_realm
code to respect the "Starting tomorrow, users in your organization will
receive updated" behavior promised to admins in the initial DMs.
Closes#34984.
For Slack, Mattermost and RocketChat, set the default announcement
channels if the sane default channel is available in the import.
The next commit will add a mechanism to choose an alternative default if
the expected channel name is not present.
Addresses the major part of #34984.
Some installations will change `dn` when a user marries, and also for
Active Directory and various other LDAP providers I've checked,
there's often a better value to use.
Previously, due to a logic issue, the clear status icon did not
appear when there is only selected emoji in the status—it appeared
only when status text was present.
This commit fixes the bug and now the clear status icon disappears
only when neither status text nor a selected emoji is present.
Fixes: #35176
This commit adds maxlength attribute with value set to 100 to
name inputs in both "Manage user" and "Manage bot" modals since
we allow maximum 100 characters for both user and bot names.
The "maxlength" attribute for "Full name" input in "Profile"
settings panel was incorrectly set to 60, when we allow
maximum 100 characters. This commit fixes that.
Partially fixes#35129.
Prettier could not be used because of prettier issue number 12209, not
linked here to avoid spam backlinks on the original issue. Prettier does
not have support for mdx v2 and v3.
We are using remarkLintRulesLintRecommended and
remarkPresentLintMarkdownStyleGuide as our starting set of rules.
None of the rules were giving an error on the starting set, but some
rules were giving lots of warnings on the generated mdx. They are
set to false in this file, we can add them back later as and when
required.
We have not inserted this in the main lint tool, we should do that in
the final cutover PR since we don't want the lint here to give any
unexpected warnings when people are linting stuff unrelated to the mdx
files.
This commit has been tested out on the current state of help center to
not produce any errors or warnings. The first run of format will produce
tons of warnings which are the issues being auto-fixed by the linter.
After that, the second run should produce zero errors.
The linting in our new help center does not allow empty urls, so we
need to fix it at source before conversion. We replace these with
destinations on the current page.
This repeats #34801, but also covers the cases where the msgstr was
already trimmed, because the translator did not bother to include the
leading/trailing whitespace in their translations.
