Commit Graph

3074 Commits

Author SHA1 Message Date
Sahil Batra
feaaf9ff03 drodpown: Do not use fa-ban icon for disabled option. 2025-10-20 16:30:06 -07:00
Sahil Batra
60074db0ed dropdown-widget: Remove left padding for icons.
This commit removes left padding for the stream privacy
and disabled icon in dropdown widgets. There is already
a padding in grid container and we are fine with removing
the 2px padding to avoid maintaining more pixel values.
2025-10-20 16:30:06 -07:00
Sahil Batra
46f338f54f dropdown-widget: Fix alignment of disabled option.
The alignment of icon and text of the disabled option in
dropdown widget was somewhow broken due to an extra span
element present which broke the grid layout used for
rendering the icon and text properly.

This also makes the layout consistent with other options
shown with icon.

This was due to e643d7e6fd which resulted in space
between icon and text. We could have fix that by using
"~" character to remove whitespace in handlebar templates
but making the layout consistent felt a better choice.
2025-10-20 16:30:06 -07:00
Lauryn Menard
6b6a02f932 demo-orgs: Fix configure email banner action button on modals.
Fixes the action button on the configure email banner that appears
before a demo organization owner has added an email address on the
invite user and convert demo organization modals.

Adds the banner-wrapper class so that the general CSS rules for
banners are applied.

Removes the extra padding on the button as it does not appear to
be necessary any longer as the font and line height for the banner
label and action buttons is now the same.
2025-10-20 11:29:05 -07:00
Alex Vandiver
52ba675a26 Revert "compose: Track when the recipient box has recently had focus."
This reverts commits 5ce956c9bb and
14c51bd0ec, which broke the compose box
in channels with "only general chat" set.
2025-10-16 19:02:15 +00:00
Lauryn Menard
69a8ec3ae9 create-realm: Remove margin-top rules for new-organization-button.
The top margin for the submit button on `create_realm.html` is
set by the '#new-realm-creation .register-button' rule in
`portico_signin.css`.

Removes the redundant margin-top rules for new-organization-button
class that are not used.
2025-10-13 10:08:14 -07:00
Lauryn Menard
e98cf5819c create-realm: Remove CSS rule for 'input.new-organization-button'.
In commit 7afbc9d, the button to create a new organization in
`templates/zerver/create_realm.html` was changed from an input
element to a button element.

Removes CSS rule that's been unused since that change.
2025-10-13 10:08:14 -07:00
Shubham Padia
66466760a0 css: Move out --box-shadow-overlay out of dark_theme.css.
Fixes #35881.
2025-10-08 23:35:46 -07:00
Shubham Padia
d9b7d8d2a6 overlay: Make sure all overlays have the same box shadow in dark mode.
Drafts, scheduled messages and message edit history had different
box-shadow done in #25771. The main reason for the different color was
for these overlays with the new background colors to play nice with the
then message/sidebar sections using the old background colors. Since
there is no such difference anymore, we can have one box-shadow for all
overlays.
2025-10-08 23:35:46 -07:00
Lauryn Menard
5b5292d138 templates: Remove unnecessary "margin" class from register template.
Removes the instances of the "margin" class from register.html and
the portico CSS rule. Doing so does not result in any visible
changes in the only place it was being applied the terms of service
checkbox on the page.
2025-10-08 17:05:28 -07:00
Shubham Padia
7bce6361b3 css: Do not use non-color values inside light-dark().
Non-color values are not permitted inside light-dark(). This commit
fixes that for --color-invalid-input-box-shadow.
2025-10-08 15:04:41 -07:00
Shubham Padia
9b1b52ec8a settings: Rename grey-box to settings-highlight-box.
Having the class named after a color limited to things we can do with
the class + does not signify what the class is for in terms of it's use.

Name decided at
https://chat.zulip.org/#narrow/channel/101-design/topic/grey-box.20dark.20theme.20color.2E/near/2272404
2025-10-07 09:26:51 -07:00
Shubham Padia
da0fa1349c css: Use --color-background-modal-bar for .grey-box.
Before 567e8f369e, the background-color
for .grey-box was --color-background-modal-bar, but the dark part out of
the light-dark() for that color was being overriden by
hsl(0deg 0% 0% / 20%) in dark_theme.css. Since that was a refactor PR,
we added a new color called --color-background-grey-box to keep the
behaviour same as before.

But discussion in
https://chat.zulip.org/#narrow/channel/101-design/topic/grey-box.20dark.20theme.20color.2E
confirmed that we want to have `--color-background-modal-bar` as the
background color for that class.
2025-10-07 09:26:51 -07:00
Shubham Padia
44d1343158 css: Remove redundant border-color for message rows.
The dark component out of the light-dark() of
--color-message-list-border is hsl(0deg 0% 0% / 40%), which is the same
as the color we specify in dark_theme.css.

- .recipient_row already uses the above variable, so it's entry is not
  needed in dark_theme.css
- .message_row uses the same variable as well.
- .overlay-message-row does not have a direct border. Although
  .message_row nested inside it does. It already uses the above
  variable, so we can remove this entry as well.
2025-10-06 17:44:11 -07:00
Shubham Padia
f6d972048b css: Remove redundant border related css for .preview_message_area.
We removed the border declaration in #29953. We do not need the
border-radius anymore, nor the border-color declaration in
dark_theme.css.
2025-10-06 17:44:11 -07:00
Shubham Padia
de2126d240 subscriptions: Use light-dark() instead of dark_theme.css for stream-row.
Fixes part of #35881.

We extract out relevant colors from dark_theme.css for .stream-row and
.group-row and place them in light-dark(). We also transform all these
colors for .group-row and .stream-row into variables.

We use the alpha value for hsl() colors as a stand-in for the opacity we
were defining in dark_theme.css.
2025-10-06 17:44:11 -07:00
Shubham Padia
567e8f369e css: Move out background-color hsl(0deg 0% 0% / 20%) out of dark_theme.
Fixes part of #35881.
2025-10-06 17:44:05 -07:00
Shubham Padia
c96caded1f subscriptions: Use existing variable for .subscriber-list-box.
Fixes part of #35881.

Instead of having all the rules in the dark_theme.css, we use the
existing variable which uses `light-dark()`.

We also create a new variable color-border-settings-radio-input-parent,
since the existing variable was not created for that radio input and
they should be allowed to change independently.
2025-10-06 17:44:00 -07:00
Shubham Padia
ee298be34b subscriptions: Replace svg with .sub-unsub-icon in dark_theme.css.
We missed doing so in #36047.
2025-10-06 17:43:23 -07:00
Evy Kassirer
9d532baa94 pill_input: Use flex-grow 1 on all input pills.
This extends existing styling for pills for search and org permissions,
to fix a bug in the invite users modal. Continues work in #34371, which
tested other input elements.

Fixes bug reported here:
https://chat.zulip.org/#narrow/channel/9-issues/topic/pasting.20invite.20email.20addresses
2025-10-06 17:32:58 -07:00
Sayam Samal
a8387a6487 dark_theme: Clean up input styles in dark_theme.css.
Fixes part of #35135.
2025-10-03 18:18:27 -07:00
Karl Stolley
31e5e8f636 left_sidebar: Remove open-menu outline on zoomed channel. 2025-10-03 16:59:46 -07:00
Karl Stolley
f82a1f3002 left_sidebar: Correct filter backgrounds on active-filter zoom. 2025-10-03 16:59:46 -07:00
Karl Stolley
d61e86faff left_sidebar: Clarify and correct active-filter hover backgrounds. 2025-10-03 16:59:46 -07:00
Karl Stolley
1b164c680e left_sidebar: Clarify hover backgrounds on active filters. 2025-10-03 16:59:46 -07:00
Karl Stolley
3b4c5abd82 left_sidebar: Specify app background color on checkmark. 2025-10-03 16:59:46 -07:00
Karl Stolley
00e437caa7 sidebars: Remove unnecessary opaque color variant.
There is no longer any opacity in the
--color-background-hover-narrow-filter, so the opaque
variant just adds noise and the potential for drift
from the original color.
2025-10-03 16:59:46 -07:00
Karl Stolley
023fd27bcb left_sidebar: Remove unnecessary dark-mode color. 2025-10-03 16:59:46 -07:00
Evy Kassirer
d9fded98ff search: Remove outline for focused pills in the typeahead.
Reported here:
https://chat.zulip.org/#narrow/channel/9-issues/topic/extraneous.20box.20when.20clicking.20on.20search.20pill.20in.20typeahead/near/2268435
2025-10-03 10:49:55 -07:00
Evy Kassirer
235dfa5280 search: Fix some overflow issues for dm pill operand. 2025-10-02 10:24:33 -07:00
Sayam Samal
0d9e503add drafts: Add placeholder text for drafts with no channel selected.
This commit handles the empty channel placeholder for drafts saved
without a channel selected. When these drafts also do not have a topic,
we display "No topic selected" in tandem with "No channel selected",
since we are unable to access the channel configuration to determine
if we should display realm_empty_topic_display_name.
2025-09-30 11:37:16 -07:00
Sahil Batra
e3fb292fb1 settings: Fix input field overflowing in channel and group edit UI.
Name input for stream and group edit modal was too wide in narrow
width screens and overflowed the modal. This commit adds CSS to
make sure that maximum width of input field is set to fit inside
the modal respecting the modal container paddings on narrow width
screens.

Fixes #35301.
2025-09-30 11:26:25 -07:00
Shubham Padia
c3fbe00eb0 help: Add default page to display on /help when help server is off.
We've copied the button and error colors from portico_signin.css. We did
not want the new HTML file to depend on portico_signin.css since they
are unrelated. In addition, having those colors diverge over time might
not be an issue.

We make the raw mode work with /help and /help/ both.

See https://chat.zulip.org/#narrow/channel/19-documentation/topic/edits.20not.20appearing.20with.20vagrant/near/2257442

Co-authored-by: Alya Abbott <alya@zulip.com>
2025-09-26 11:41:10 -07:00
Aman Agrawal
8b8d23cc5f realm_redirect: Add help for self hosted users to login. 2025-09-26 11:02:26 -07:00
Sahil Batra
aa0051abc2 image_upload_widget: Remove blue outline when clicking.
"Upload profile picture" and similar text shown when hovering
over the image shows a blue outline while clicking on it
and same blue outline is shown when clicking on the delete
button ("x") as well. This commit updates the CSS to remove
that outline.
2025-09-26 09:19:45 -07:00
Aman Agrawal
f2a11c5858 inbox: Avoid extra margin from folders hidden by filters.
If all channels in a folder are muted, then this margin is present
in "Standard view", without there being any folder present.

Fixed by only applying margin if the folder has any header or rows
that are not hidden by filters.

This is an alternative fix to #35962 which was reverted in #36123.
2025-09-26 09:16:26 -07:00
Karl Stolley
c21d2918da inbox: Correct margin declaration to avoid odd gap. 2025-09-25 17:27:35 -07:00
Evy Kassirer
fc9bbd37a0 search: Align suggestion left padding with search bar icon space. 2025-09-23 11:39:12 -07:00
Aman Agrawal
e36147a94e realm_creation: Disable import from input.
We are not processing this input at the POST endpoint, this
commit just disables the selection from changing.

It is not easy to process changing "import from" at this stage,
but we can possible allow that in a future refactor.
2025-09-22 09:37:34 -07:00
Aman Agrawal
f45552fadd slack_import: Disable submit button if file is invalid. 2025-09-22 09:37:34 -07:00
Aman Agrawal
04fa43e1df slack_import: Don't use a tag for form submission.
This can mislead user into thinking this is a link they can
open in a new tab, which we don't want to allow.
2025-09-22 09:37:34 -07:00
Shubham Padia
310a2323b6 subscriptions: Move raw svg for plus and check icons to zulip-icon.
Fixes #35899.

We don't make any visual changes to how the svgs/icons look, we just
move them to use the zulip-icon system.

We also replace use of the raw images of each in the help center and add
appropriate color for both in the help center.
2025-09-17 14:15:05 -07:00
Karl Stolley
a64276c58f media: Replace legacy .message_inline_image class.
This introduces two new replacement classes, depending on
whether the inner content is an image or a video.
2025-09-17 13:25:50 -07:00
Karl Stolley
14c51bd0ec compose: Track when the recipient box has recently had focus.
This helps to prevent an edge case where clicking the
new-topic button, `[+]`, in the left sidebar when the
topic box was already empty caused an unexpected flash
of the *general chat* topic.
2025-09-16 11:53:46 -07:00
Karl Stolley
a4657a5bd7 compose: Correct for undesired outline flash on pills. 2025-09-16 11:53:46 -07:00
Karl Stolley
75714bb44f compose: Remove competing transitions.
The transitions here do not work correctly across all
states, and directly interfere or look goofy with the
transitions in the recipient-row area.

Particularly with the removal from #message-content-container,
that had the annoying effect of just delaying the
appearance of the focus border, regardless of whether
focus was established via keyboard or mouse.
2025-09-16 11:53:46 -07:00
Karl Stolley
de7419a528 compose: Only transition when low-attention row hovered.
Previously, if the mouse cursor were in the vicinity of
the compose box, we'd see transitions even on keyboard
interactions, which should not have been happening.

This also allows instantaneous highlighting for keyboard
users, as well as avoiding any transitions when a
mouse user clicks into a recipient-row element (at
which point the hover transitions will have already
run).
2025-09-16 11:53:46 -07:00
Karl Stolley
2fce6fa317 compose: Offset low-attention pill outlines. 2025-09-16 11:53:46 -07:00
Sayam Samal
3070c78cc5 popovers: Remove "light-border" Tippyjs theme usage.
The "light-border" theme was set as the default theme for all the
popovers, but was no longer in use, since all of our current popovers
either use the "popover-menu" theme or the "dropdown-widget" theme.

In response to the above reasoning, this commit removes the redundant
"light-border" Tippyjs theme usage from the codebase.
2025-09-15 09:25:39 -07:00
Sayam Samal
b9b1798a1e dark_theme: Clean up Tippy box styles.
Fixes part of #35880.
2025-09-15 09:25:39 -07:00