Alex Vandiver 7dc7962c04 zulip-puppet-apply: Any resources failing to apply should exit 2. ...

The existing `except subprocess.CalledProcessError` only catches if
there are syntax errors which prevent the `lastrun` file from being
written; it does not handle if there are properly-defined resources
which fail to evaluate (e.g. due to a missing dependency or file).

Check the `failed` resource count, and exit 2 if there are any such
resources.  This will cause `zulip-puppet-apply --force --noop` (which
is used as a pre-flight check during upgrades) to properly detect and
signal on more types of invalid puppet configurations.  In turn, this
will cause `upgrade-zulip` to not attempt to power through upgrades it
knows are destined to fail.

2023-04-19 09:35:19 -07:00

3.6 KiB

Executable File

Raw Permalink Blame History

View Raw