2294552080
Clicking on the stream row should open the message view as per "Channel links in the left sidebar go to" setting. But this happens only when clicking on stream name element and not on the complete stream row, like clicking on the privacy icon or towards the left of it, opens the channel feed always irrespective of the setting. This commit fixes that. Updated the code to attach the "New topic" button handler to "#stream_filters" element instead of "body", as it was not being executed due to stopPropagation being called in the click handler for "a" element for stream row. Attaching the event to "#stream_filters" makes sure that clicking on "New topic" button calls the handler for it first and stops event from being propagated to the "a" element for stream row. Also moved "New topic" handler to stream_list.ts, as it would be easy to maintain them if all handlers for the UI are in the same file. This also fixes the bug when pressing "Enter" key after clicking on a stream row did not open the compose box for replying to the selected message which is the expected behavior when "Channel links in the left sidebar go to" setting is set to value other than "List of topics".
Zulip overview
Zulip is an open-source team collaboration tool with unique topic-based threading that combines the best of email and chat to make remote work productive and delightful. Fortune 500 companies, leading open source projects, and thousands of other organizations use Zulip every day. Zulip is the only modern team chat app that is designed for both live and asynchronous conversations.
Zulip is built by a distributed community of developers from all around the world, with 74+ people who have each contributed 100+ commits. With over 1000 contributors merging over 500 commits a month, Zulip is the largest and fastest growing open source team chat project.
Come find us on the development community chat!
Getting started
-
Contributing code. Check out our guide for new contributors to get started. We have invested in making Zulip’s code highly readable, thoughtfully tested, and easy to modify. Beyond that, we have written an extraordinary 150K words of documentation for Zulip contributors.
-
Contributing non-code. Report an issue, translate Zulip into your language, or give us feedback. We'd love to hear from you, whether you've been using Zulip for years, or are just trying it out for the first time.
-
Checking Zulip out. The best way to see Zulip in action is to drop by the Zulip community server. We also recommend reading about Zulip's unique approach to organizing conversations.
-
Running a Zulip server. Self-host Zulip directly on Ubuntu or Debian Linux, in Docker, or with prebuilt images for Digital Ocean and Render. Learn more about self-hosting Zulip.
-
Using Zulip without setting up a server. Learn about Zulip Cloud hosting options. Zulip sponsors free Zulip Cloud Standard for hundreds of worthy organizations, including fellow open-source projects.
-
Participating in outreach programs like Google Summer of Code and Outreachy.
-
Supporting Zulip. Advocate for your organization to use Zulip, become a sponsor, write a review in the mobile app stores, or help others find Zulip.
You may also be interested in reading our blog, and following us on Twitter and LinkedIn.
Zulip is distributed under the Apache 2.0 license.