Alex Vandiver 8f6f38c97c cache: Decline to store querysets, with an error. ...

As we have seen no further cases of this in production since #23215,
increase the severity to an error, and switch from returning a
list (which is not type-safe if the function declares a QuerySet
return) to returning the QuerySet without caching.

Failing to store the result in the cache, with an error, seems
superior to raising an exception; in both cases the next request will
redo the work, but we are guaranteed a worse user experience if we 500
the request.

Ref https://github.com/zulip/zulip/pull/23215#discussion_r994186493

2022-11-29 16:45:11 -08:00

27 KiB

Raw Blame History

View Raw