Steve Howell 6e7fe76cf4 export: s/avatar_bucket/processing_avatars ...

The name avatar_bucket was confusing for a boolean, and
in some places it was used for non-S3 paths.

I considered the more concise 'is_avatar', but that
was still confusing when you are processing multiple
files, because you think it's a calculated property
on one file instead of an overall codepath switch.

I also considered splitting up some functions, but
there is a lot of common logic between handling
file uploads and avatars that's not trivial to extract
into helpers, especially on the S3 side.

2016-08-11 15:21:30 -07:00

44 KiB

Raw Blame History

View Raw