mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
  n.Statement.check(node);
for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;
  let inLoop = false;
  let replaceReturn = false;
  const visitLoop = (...args: string[]) =>
    function(this: Context, path: NodePath) {
      for (const arg of args) {
        this.visit(path.get(arg));
      }
      const old = { inLoop };
      inLoop = true;
      this.visit(path.get("body"));
      inLoop = old.inLoop;
      return false;
    };
  recast.visit(ast, {
    visitDoWhileStatement: visitLoop("test"),
    visitExpressionStatement(path) {
      const { expression, comments } = path.node;
      let valueOnly;
      if (
        n.CallExpression.check(expression) &&
        n.MemberExpression.check(expression.callee) &&
        !expression.callee.computed &&
        n.Identifier.check(expression.callee.object) &&
        expression.callee.object.name === "_" &&
        n.Identifier.check(expression.callee.property) &&
        ["each", "forEach"].includes(expression.callee.property.name) &&
        [2, 3].includes(expression.arguments.length) &&
        checkExpression(expression.arguments[0]) &&
        (n.FunctionExpression.check(expression.arguments[1]) ||
          n.ArrowFunctionExpression.check(expression.arguments[1])) &&
        [1, 2].includes(expression.arguments[1].params.length) &&
        n.Identifier.check(expression.arguments[1].params[0]) &&
        ((valueOnly = expression.arguments[1].params[1] === undefined) ||
          n.Identifier.check(expression.arguments[1].params[1])) &&
        (expression.arguments[2] === undefined ||
          n.ThisExpression.check(expression.arguments[2]))
      ) {
        const old = { inLoop, replaceReturn };
        inLoop = false;
        replaceReturn = true;
        this.visit(
          path
            .get("expression")
            .get("arguments")
            .get(1)
            .get("body")
        );
        inLoop = old.inLoop;
        replaceReturn = old.replaceReturn;
        const [right, { body, params }] = expression.arguments;
        const loop = b.forOfStatement(
          b.variableDeclaration("let", [
            b.variableDeclarator(
              valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
            ),
          ]),
          valueOnly
            ? right
            : b.callExpression(
                b.memberExpression(right, b.identifier("entries")),
                []
              ),
          checkStatement(body) ? body : b.expressionStatement(body)
        );
        loop.comments = comments;
        path.replace(loop);
        changed = true;
      }
      this.traverse(path);
    },
    visitForStatement: visitLoop("init", "test", "update"),
    visitForInStatement: visitLoop("left", "right"),
    visitForOfStatement: visitLoop("left", "right"),
    visitFunction(path) {
      this.visit(path.get("params"));
      const old = { replaceReturn };
      replaceReturn = false;
      this.visit(path.get("body"));
      replaceReturn = old.replaceReturn;
      return false;
    },
    visitReturnStatement(path) {
      if (replaceReturn) {
        assert(!inLoop); // could use labeled continue if this ever fires
        const { argument, comments } = path.node;
        if (argument === null) {
          const s = b.continueStatement();
          s.comments = comments;
          path.replace(s);
        } else {
          const s = b.expressionStatement(argument);
          s.comments = comments;
          path.replace(s, b.continueStatement());
        }
        return false;
      }
      this.traverse(path);
    },
    visitWhileStatement: visitLoop("test"),
  });
  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
		
	
		
			
				
	
	
		
			98 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			98 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
const max_topics = 5;
 | 
						|
const max_topics_with_unread = 8;
 | 
						|
 | 
						|
exports.get_list_info = function (stream_id, zoomed) {
 | 
						|
    let topics_selected = 0;
 | 
						|
    let more_topics_unreads = 0;
 | 
						|
 | 
						|
    let active_topic = narrow_state.topic();
 | 
						|
 | 
						|
    if (active_topic) {
 | 
						|
        active_topic = active_topic.toLowerCase();
 | 
						|
    }
 | 
						|
 | 
						|
    const topic_names = topic_data.get_recent_names(stream_id);
 | 
						|
 | 
						|
    const items = [];
 | 
						|
 | 
						|
    for (const [idx, topic_name] of topic_names.entries()) {
 | 
						|
        const num_unread = unread.num_unread_for_topic(stream_id, topic_name);
 | 
						|
        const is_active_topic = active_topic === topic_name.toLowerCase();
 | 
						|
        const is_topic_muted = muting.is_topic_muted(stream_id, topic_name);
 | 
						|
 | 
						|
        if (!zoomed) {
 | 
						|
            function should_show_topic(topics_selected) {
 | 
						|
                // This function exists just for readability, to
 | 
						|
                // avoid long chained conditionals to determine
 | 
						|
                // which topics to include.
 | 
						|
 | 
						|
                // We always show the active topic.  Ideally, this
 | 
						|
                // logic would first check whether the active
 | 
						|
                // topic is in the set of those with unreads to
 | 
						|
                // avoid ending up with max_topics_with_unread + 1
 | 
						|
                // total topics if the active topic comes after
 | 
						|
                // the first several topics with unread messages.
 | 
						|
                if (is_active_topic) {
 | 
						|
                    return true;
 | 
						|
                }
 | 
						|
 | 
						|
                // We unconditionally skip showing muted topics
 | 
						|
                // when not zoomed, even if they have unread
 | 
						|
                // messages.
 | 
						|
                if (is_topic_muted) {
 | 
						|
                    return false;
 | 
						|
                }
 | 
						|
 | 
						|
                // We include the most recent max_topics topics,
 | 
						|
                // even if there are no unread messages.
 | 
						|
                if (idx < max_topics) {
 | 
						|
                    return true;
 | 
						|
                }
 | 
						|
 | 
						|
                // We include older topics with unread messages up
 | 
						|
                // until max_topics_with_unread total topics have
 | 
						|
                // been included.
 | 
						|
                if (num_unread > 0 && topics_selected < max_topics_with_unread) {
 | 
						|
                    return true;
 | 
						|
                }
 | 
						|
 | 
						|
                // Otherwise, we don't show the topic in the
 | 
						|
                // unzoomed view.  We might display its unread
 | 
						|
                // count in in "more topics" if it is not muted.
 | 
						|
                return false;
 | 
						|
            }
 | 
						|
 | 
						|
            const show_topic = should_show_topic(topics_selected);
 | 
						|
            if (!show_topic) {
 | 
						|
                if (!is_topic_muted) {
 | 
						|
                    // The "more topics" unread count, like
 | 
						|
                    // stream-level counts, only counts messages
 | 
						|
                    // on unmuted topics.
 | 
						|
                    more_topics_unreads += num_unread;
 | 
						|
                }
 | 
						|
                continue;
 | 
						|
            }
 | 
						|
            topics_selected += 1;
 | 
						|
            // We fall through to rendering the topic, using the
 | 
						|
            // same code we do when zoomed.
 | 
						|
        }
 | 
						|
 | 
						|
        const topic_info = {
 | 
						|
            topic_name: topic_name,
 | 
						|
            unread: num_unread,
 | 
						|
            is_zero: num_unread === 0,
 | 
						|
            is_muted: is_topic_muted,
 | 
						|
            is_active_topic: is_active_topic,
 | 
						|
            url: hash_util.by_stream_topic_uri(stream_id, topic_name),
 | 
						|
        };
 | 
						|
 | 
						|
        items.push(topic_info);
 | 
						|
    }
 | 
						|
 | 
						|
    return {
 | 
						|
        items: items,
 | 
						|
        num_possible_topics: topic_names.length,
 | 
						|
        more_topics_unreads: more_topics_unreads,
 | 
						|
    };
 | 
						|
};
 |