mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 23:13:25 +00:00
02511bff1c
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
111 lines
3.5 KiB
JavaScript
111 lines
3.5 KiB
JavaScript
const render_alert_word_settings_item = require('../templates/alert_word_settings_item.hbs');
|
|
|
|
exports.render_alert_words_ui = function () {
|
|
const words = alert_words.words;
|
|
const word_list = $('#alert_words_list');
|
|
|
|
word_list.find('.alert-word-item').remove();
|
|
|
|
for (const alert_word of words) {
|
|
const rendered_alert_word = render_alert_word_settings_item({
|
|
word: alert_word,
|
|
editing: false,
|
|
});
|
|
word_list.append(rendered_alert_word);
|
|
}
|
|
|
|
const new_alert_word_form = render_alert_word_settings_item({
|
|
word: '',
|
|
editing: true,
|
|
});
|
|
word_list.append(new_alert_word_form);
|
|
|
|
// Focus new alert word name text box.
|
|
$('#create_alert_word_name').focus();
|
|
};
|
|
|
|
function update_alert_word_status(status_text, is_error) {
|
|
const alert_word_status = $('#alert_word_status');
|
|
if (is_error) {
|
|
alert_word_status.removeClass('alert-success').addClass('alert-danger');
|
|
} else {
|
|
alert_word_status.removeClass('alert-danger').addClass('alert-success');
|
|
}
|
|
alert_word_status.find('.alert_word_status_text').text(status_text);
|
|
alert_word_status.show();
|
|
}
|
|
|
|
function add_alert_word(alert_word) {
|
|
alert_word = $.trim(alert_word);
|
|
if (alert_word === '') {
|
|
update_alert_word_status(i18n.t("Alert word can't be empty!"), true);
|
|
return;
|
|
} else if (alert_words.words.indexOf(alert_word) !== -1) {
|
|
update_alert_word_status(i18n.t("Alert word already exists!"), true);
|
|
return;
|
|
}
|
|
|
|
const words_to_be_added = [alert_word];
|
|
|
|
channel.post({
|
|
url: '/json/users/me/alert_words',
|
|
data: {alert_words: JSON.stringify(words_to_be_added)},
|
|
success: function () {
|
|
update_alert_word_status(i18n.t("Alert word added successfully!"), false);
|
|
},
|
|
error: function () {
|
|
update_alert_word_status(i18n.t("Error adding alert word!"), true);
|
|
},
|
|
});
|
|
}
|
|
|
|
function remove_alert_word(alert_word) {
|
|
const words_to_be_removed = [alert_word];
|
|
|
|
channel.del({
|
|
url: '/json/users/me/alert_words',
|
|
data: {alert_words: JSON.stringify(words_to_be_removed)},
|
|
success: function () {
|
|
update_alert_word_status(i18n.t("Alert word removed successfully!"), false);
|
|
},
|
|
error: function () {
|
|
update_alert_word_status(i18n.t("Error removing alert word!"), true);
|
|
},
|
|
});
|
|
}
|
|
|
|
exports.set_up_alert_words = function () {
|
|
// The settings page must be rendered before this function gets called.
|
|
|
|
exports.render_alert_words_ui();
|
|
|
|
$('#alert_words_list').on('click', '#create_alert_word_button', function () {
|
|
const word = $('#create_alert_word_name').val();
|
|
add_alert_word(word);
|
|
});
|
|
|
|
$('#alert_words_list').on('click', '.remove-alert-word', function (event) {
|
|
const word = $(event.currentTarget).parents('li').find('.value').text();
|
|
remove_alert_word(word);
|
|
});
|
|
|
|
$('#alert_words_list').on('keypress', '#create_alert_word_name', function (event) {
|
|
const key = event.which;
|
|
// Handle enter (13) as "add".
|
|
if (key === 13) {
|
|
event.preventDefault();
|
|
|
|
const word = $(event.target).val();
|
|
add_alert_word(word);
|
|
}
|
|
});
|
|
|
|
$('#alert-word-settings').on('click', '.close-alert-word-status', function (event) {
|
|
event.preventDefault();
|
|
const alert = $(event.currentTarget).parents('.alert');
|
|
alert.hide();
|
|
});
|
|
};
|
|
|
|
window.alert_words_ui = exports;
|