Mateusz Mandera 50bfbb588e subs: Allow filtering by is_user_active in get_active_subscriptions. ...

get_active_subscriptions_for_stream_id should allow specifying whether
subscriptions of deactivated users should be included in the result.
Active subs of deactivated users are  a subtlety that's easy to miss
when writing relevant code, so we make include_deactivated_users a
mandatory kwarg - this will force callers to definitely give thought to
whether such subs should be included or not.

This commit is just a refactoring, we keep original behavior everywhere
- there are places where subs of deactivates users should probably be
excluded but aren't - we don't fix that here, it'll be addressed in
follow-up commits.

2021-04-19 10:10:51 -07:00

1.0 KiB

Raw Blame History

View Raw