Alex Vandiver a40b3e1118 realm_emoji: Stop swallowing all exceptions from upload_emoji_image. ...

Putting all of the logic in a `finally` block is equivalent to a bare
`except` block, which silently consumes all exceptions.

Move only the most-necessary parts into the except; this lets
`BadImageError` exceptions from `zerver/lib/upload.py` to escape,
allowing better the generic "Image file upload failed" to be replaced
with a more specific message.

It also allows unexpected exceptions, as the previous commit resolved,
to escape and 500.  This lets them be detected and resolved, rather
than give users a silently bad experience.

2022-02-17 12:19:47 -08:00

317 KiB

Raw Blame History

View Raw