mirror of
https://github.com/zulip/zulip.git
synced 2025-11-11 17:36:27 +00:00
We now treat util like a leaf module and use "require" to import it everywhere it's used. An earlier version of this commit moved util into our "shared" library, but we decided to wait on that. Once we're ready to do that, we should only need to do a simple search/replace on various require/zrequire statements plus a small tweak to one of the custom linter checks. It turns out we don't really need util.js for our most immediate code-sharing goal, which is to reuse our markdown code on mobile. There's a little bit of cleanup still remaining to break the dependency, but it's minor. The util module still calls the global blueslip module in one place, but that code is about to be removed in the next few commits. I am pretty confident that once we start sharing things like the typeahead code more aggressively, we'll start having dependencies on util. The module is barely more than 300 lines long, so we'll probably just move the whole thing into shared rather than break it apart. Also, we can continue to nibble away at the cruftier parts of the module.
184 lines
4.9 KiB
JavaScript
184 lines
4.9 KiB
JavaScript
set_global('$', global.make_zjquery());
|
|
|
|
const _people = {
|
|
small_avatar_url_for_person: function () {
|
|
return 'http://example.com/example.png';
|
|
},
|
|
};
|
|
|
|
set_global('people', _people);
|
|
|
|
zrequire('compose_pm_pill');
|
|
zrequire('input_pill');
|
|
zrequire('user_pill');
|
|
|
|
let pills = {
|
|
pill: {},
|
|
};
|
|
|
|
run_test('pills', () => {
|
|
const othello = {
|
|
user_id: 1,
|
|
email: 'othello@example.com',
|
|
full_name: 'Othello',
|
|
};
|
|
|
|
const iago = {
|
|
email: 'iago@zulip.com',
|
|
user_id: 2,
|
|
full_name: 'Iago',
|
|
};
|
|
|
|
const hamlet = {
|
|
email: 'hamlet@example.com',
|
|
user_id: 3,
|
|
full_name: 'Hamlet',
|
|
};
|
|
|
|
people.get_realm_persons = function () {
|
|
return [iago, othello, hamlet];
|
|
};
|
|
|
|
const recipient_stub = $("#private_message_recipient");
|
|
const pill_container_stub = $('.pill-container[data-before="You and"]');
|
|
recipient_stub.set_parent(pill_container_stub);
|
|
let create_item_handler;
|
|
|
|
const all_pills = new Map();
|
|
|
|
pills.appendValidatedData = function (item) {
|
|
const id = item.user_id;
|
|
assert(!all_pills.has(id));
|
|
all_pills.set(id, item);
|
|
};
|
|
pills.items = function () {
|
|
return Array.from(all_pills.values());
|
|
};
|
|
|
|
let text_cleared;
|
|
pills.clear_text = function () {
|
|
text_cleared = true;
|
|
};
|
|
|
|
let pills_cleared;
|
|
pills.clear = function () {
|
|
pills_cleared = true;
|
|
pills = {
|
|
pill: {},
|
|
};
|
|
all_pills.clear();
|
|
};
|
|
|
|
let appendValue_called;
|
|
pills.appendValue = function (value) {
|
|
appendValue_called = true;
|
|
assert.equal(value, 'othello@example.com');
|
|
this.appendValidatedData(othello);
|
|
};
|
|
|
|
let get_by_email_called = false;
|
|
people.get_by_email = function (user_email) {
|
|
get_by_email_called = true;
|
|
if (user_email === iago.email) {
|
|
return iago;
|
|
}
|
|
if (user_email === othello.email) {
|
|
return othello;
|
|
}
|
|
};
|
|
|
|
let get_by_user_id_called = false;
|
|
people.get_by_user_id = function (id) {
|
|
get_by_user_id_called = true;
|
|
if (id === othello.user_id) {
|
|
return othello;
|
|
}
|
|
assert.equal(id, 3);
|
|
return hamlet;
|
|
};
|
|
|
|
function test_create_item(handler) {
|
|
(function test_rejection_path() {
|
|
const item = handler(othello.email, pills.items());
|
|
assert(get_by_email_called);
|
|
assert.equal(item, undefined);
|
|
}());
|
|
|
|
(function test_success_path() {
|
|
get_by_email_called = false;
|
|
const res = handler(iago.email, pills.items());
|
|
assert(get_by_email_called);
|
|
assert.equal(typeof res, 'object');
|
|
assert.equal(res.user_id, iago.user_id);
|
|
assert.equal(res.display_value, iago.full_name);
|
|
}());
|
|
}
|
|
|
|
function input_pill_stub(opts) {
|
|
assert.equal(opts.container, pill_container_stub);
|
|
create_item_handler = opts.create_item_from_text;
|
|
assert(create_item_handler);
|
|
return pills;
|
|
}
|
|
|
|
input_pill.create = input_pill_stub;
|
|
|
|
compose_pm_pill.initialize();
|
|
assert(compose_pm_pill.widget);
|
|
|
|
compose_pm_pill.set_from_typeahead(othello);
|
|
compose_pm_pill.set_from_typeahead(hamlet);
|
|
|
|
const user_ids = compose_pm_pill.get_user_ids();
|
|
assert.deepEqual(user_ids, [othello.user_id, hamlet.user_id]);
|
|
|
|
const user_ids_string = compose_pm_pill.get_user_ids_string();
|
|
assert.equal(user_ids_string, '1,3');
|
|
|
|
const emails = compose_pm_pill.get_emails();
|
|
assert.equal(emails, 'othello@example.com,hamlet@example.com');
|
|
|
|
const persons = [othello, iago, hamlet];
|
|
const items = compose_pm_pill.filter_taken_users(persons);
|
|
assert.deepEqual(items, [{email: 'iago@zulip.com', user_id: 2, full_name: 'Iago'}]);
|
|
|
|
test_create_item(create_item_handler);
|
|
|
|
compose_pm_pill.set_from_emails('othello@example.com');
|
|
assert(compose_pm_pill.widget);
|
|
|
|
assert(get_by_user_id_called);
|
|
assert(pills_cleared);
|
|
assert(appendValue_called);
|
|
assert(text_cleared);
|
|
});
|
|
|
|
run_test('has_unconverted_data', () => {
|
|
compose_pm_pill.widget = {
|
|
is_pending: () => true,
|
|
};
|
|
|
|
// If the pill itself has pending data, we have unconverted
|
|
// data.
|
|
assert.equal(compose_pm_pill.has_unconverted_data(), true);
|
|
|
|
compose_pm_pill.widget = {
|
|
is_pending: () => false,
|
|
items: () => [{user_id: 99}],
|
|
};
|
|
|
|
// Our pill is complete and all items containt user_id, so
|
|
// we do NOT have unconverted data.
|
|
assert.equal(compose_pm_pill.has_unconverted_data(), false);
|
|
|
|
compose_pm_pill.widget = {
|
|
is_pending: () => false,
|
|
items: () => [{user_id: 99}, {email: 'random@mit.edu'}],
|
|
};
|
|
|
|
// One of our items only knows email (as in a bridge-with-zephyr
|
|
// scenario where we might not have registered the user yet), so
|
|
// we have some unconverted data.
|
|
assert.equal(compose_pm_pill.has_unconverted_data(), true);
|
|
});
|