Files
zulip/frontend_tests/node_tests/dispatch_subs.js
Anders Kaseorg 876806eb4d zjsunit: Lift restriction against mocking third party modules.
Use fully resolvable request paths because we need to be able to refer
to third party modules, and to increase uniformity and explicitness.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-12 10:06:30 -08:00

266 lines
8.1 KiB
JavaScript

"use strict";
const {strict: assert} = require("assert");
const {mock_esm, set_global, zrequire} = require("../zjsunit/namespace");
const {make_stub} = require("../zjsunit/stub");
const {run_test} = require("../zjsunit/test");
const events = require("./lib/events");
const event_fixtures = events.fixtures;
const test_user = events.test_user;
const compose_fade = mock_esm("../../static/js/compose_fade");
const narrow_state = mock_esm("../../static/js/narrow_state");
const overlays = mock_esm("../../static/js/overlays");
const page_params = set_global("page_params", {});
const settings_org = mock_esm("../../static/js/settings_org");
const settings_streams = mock_esm("../../static/js/settings_streams");
const stream_events = mock_esm("../../static/js/stream_events");
const stream_list = mock_esm("../../static/js/stream_list");
const subs = mock_esm("../../static/js/subs");
set_global("current_msg_list", {});
const peer_data = zrequire("peer_data");
const people = zrequire("people");
const stream_data = zrequire("stream_data");
const server_events_dispatch = zrequire("server_events_dispatch");
const noop = () => {};
people.add_active_user(test_user);
const me = {
email: "me@zulip.com",
full_name: "Me Myself",
user_id: 101,
};
people.add_active_user(me);
people.initialize_current_user(me.user_id);
const dispatch = server_events_dispatch.dispatch_normal_event;
function test(label, f) {
run_test(label, (override) => {
stream_data.clear_subscriptions();
f(override);
});
}
test("add", (override) => {
const event = event_fixtures.subscription__add;
const sub = event.subscriptions[0];
const stream_id = sub.stream_id;
stream_data.add_sub({
stream_id,
name: sub.name,
});
const subscription_stub = make_stub();
override(stream_events, "mark_subscribed", subscription_stub.f);
dispatch(event);
assert.equal(subscription_stub.num_calls, 1);
const args = subscription_stub.get_args("sub", "subscribers");
assert.deepEqual(args.sub.stream_id, stream_id);
assert.deepEqual(args.subscribers, event.subscriptions[0].subscribers);
});
test("peer add/remove", (override) => {
let event = event_fixtures.subscription__peer_add;
stream_data.add_sub({
name: "devel",
stream_id: event.stream_ids[0],
});
const subs_stub = make_stub();
override(subs, "update_subscribers_ui", subs_stub.f);
const compose_fade_stub = make_stub();
override(compose_fade, "update_faded_users", compose_fade_stub.f);
dispatch(event);
assert.equal(compose_fade_stub.num_calls, 1);
assert.equal(subs_stub.num_calls, 1);
assert(peer_data.is_user_subscribed(event.stream_ids[0], event.user_ids[0]));
event = event_fixtures.subscription__peer_remove;
dispatch(event);
assert.equal(compose_fade_stub.num_calls, 2);
assert.equal(subs_stub.num_calls, 2);
assert(!peer_data.is_user_subscribed(event.stream_ids[0], event.user_ids[0]));
});
test("remove", (override) => {
const event = event_fixtures.subscription__remove;
const event_sub = event.subscriptions[0];
const stream_id = event_sub.stream_id;
const sub = {
stream_id,
name: event_sub.name,
};
stream_data.add_sub(sub);
const stub = make_stub();
override(stream_events, "mark_unsubscribed", stub.f);
dispatch(event);
assert.equal(stub.num_calls, 1);
const args = stub.get_args("sub");
assert.deepEqual(args.sub, sub);
});
test("update", (override) => {
const event = event_fixtures.subscription__update;
const stub = make_stub();
override(stream_events, "update_property", stub.f);
dispatch(event);
assert.equal(stub.num_calls, 1);
const args = stub.get_args("stream_id", "property", "value");
assert.deepEqual(args.stream_id, event.stream_id);
assert.deepEqual(args.property, event.property);
assert.deepEqual(args.value, event.value);
});
test("add error handling", (override) => {
// test blueslip errors/warns
const event = event_fixtures.subscription__add;
const stub = make_stub();
override(blueslip, "error", stub.f);
dispatch(event);
assert.equal(stub.num_calls, 1);
assert.deepEqual(stub.get_args("param").param, "Subscribing to unknown stream with ID 101");
});
test("peer event error handling (bad stream_ids/user_ids)", (override) => {
override(compose_fade, "update_faded_users", () => {});
const add_event = {
type: "subscription",
op: "peer_add",
stream_ids: [8888, 9999],
user_ids: [3333, 4444],
};
blueslip.expect("warn", "We have untracked stream_ids: 8888,9999");
blueslip.expect("warn", "We have untracked user_ids: 3333,4444");
dispatch(add_event);
blueslip.reset();
const remove_event = {
type: "subscription",
op: "peer_remove",
stream_ids: [8888, 9999],
user_ids: [3333, 4444],
};
blueslip.expect("warn", "We have untracked stream_ids: 8888,9999");
blueslip.expect("warn", "We have untracked user_ids: 3333,4444");
dispatch(remove_event);
});
test("stream update", (override) => {
const event = event_fixtures.stream__update;
const stub = make_stub();
override(stream_events, "update_property", stub.f);
override(settings_streams, "update_default_streams_table", noop);
dispatch(event);
assert.equal(stub.num_calls, 1);
const args = stub.get_args("stream_id", "property", "value");
assert.equal(args.stream_id, event.stream_id);
assert.equal(args.property, event.property);
assert.equal(args.value, event.value);
});
test("stream create", (override) => {
const event = event_fixtures.stream__create;
const stub = make_stub();
override(stream_data, "create_streams", stub.f);
override(stream_data, "get_sub_by_id", noop);
override(stream_data, "update_calculated_fields", noop);
override(subs, "add_sub_to_table", noop);
override(overlays, "streams_open", () => true);
dispatch(event);
assert.equal(stub.num_calls, 1);
const args = stub.get_args("streams");
assert.deepEqual(
args.streams.map((stream) => stream.stream_id),
[101, 102],
);
});
test("stream delete (normal)", (override) => {
const event = event_fixtures.stream__delete;
for (const stream of event.streams) {
stream_data.add_sub(stream);
}
stream_data.subscribe_myself(event.streams[0]);
override(stream_data, "delete_sub", noop);
override(settings_streams, "update_default_streams_table", noop);
narrow_state.is_for_stream_id = () => true;
let bookend_updates = 0;
override(current_msg_list, "update_trailing_bookend", () => {
bookend_updates += 1;
});
const removed_stream_ids = [];
override(subs, "remove_stream", (stream_id) => {
removed_stream_ids.push(stream_id);
});
let removed_sidebar_rows = 0;
override(stream_list, "remove_sidebar_row", () => {
removed_sidebar_rows += 1;
});
dispatch(event);
assert.deepEqual(removed_stream_ids, [event.streams[0].stream_id, event.streams[1].stream_id]);
// We should possibly be able to make a single call to
// update_trailing_bookend, but we currently do it for each stream.
assert.equal(bookend_updates, 2);
assert.equal(removed_sidebar_rows, 1);
});
test("stream delete (special streams)", (override) => {
const event = event_fixtures.stream__delete;
for (const stream of event.streams) {
stream_data.add_sub(stream);
}
// sanity check data
assert.equal(event.streams.length, 2);
page_params.realm_notifications_stream_id = event.streams[0].stream_id;
page_params.realm_signup_notifications_stream_id = event.streams[1].stream_id;
override(subs, "remove_stream", noop);
override(settings_org, "sync_realm_settings", noop);
override(settings_streams, "update_default_streams_table", noop);
override(current_msg_list, "update_trailing_bookend", noop);
override(stream_list, "remove_sidebar_row", noop);
dispatch(event);
assert.equal(page_params.realm_notifications_stream_id, -1);
assert.equal(page_params.realm_signup_notifications_stream_id, -1);
});