Elliott Jin fde1aa506b tests: Prevent misuse of assert_in_success_response. ...

Changing assert_in_success_response to require List[Text] instead of
Iterable[Text] prevents the following misuse:

    self.assert_in_response_success("message", response)

Currently, this will check whether 'm', 'e', 's', 'a', and 'g' separately
appear in the response, which is probably not the intended behavior.  The
correct usage is as follows:

    self.assert_in_response_success(["message"], response)

2017-03-18 15:49:35 -07:00

21 KiB

Raw Blame History

View Raw