* Browser-like loading indicator added to the sidebar.
Shows when the app is loading a page. Inactive once the user starts
navigating on the webpage, and in settings.
* Add tooltip saying "Loading" to indicator.
Fixes#430.
* Add View menu shortcut to hide menu bar
The hide menu bar setting available in General Preferences has been added to the View menu.
* settings: Add method to coordinate menu & settings
Use autoHideMenuBar setting with said method.
This PR removes .ogg file check (supported only by very old servers). Other enhancements in server validation logic -
* Reject domains with no organizations.
* Convert validation methods to async await
* Add messages.js for returning error message strings.
Fixes: #596, #573.
Minifies the current development guide by
a significant amount. Also, removes system requirements
as no credible source for them. Removes dependency
specific instructions and adds links to instructions
to install them.
Fixes#341.
Adds an option to enable or disable sentry error
reporting under Advanced section in General Settings.
Handles both main and renderer processes.
Also, changes the domain used to resolve proxy
in proxy-util from google.com to example.com.
Fixes#702.
There is a bug with electron-builder where it doesn't name the installer properly.
Without this config, it always names the installer with spaces in between
i.e. "Zulip Web Setup.exe".
Allow the nsis installer to install the app to
AppData for a single user so that administrator
previliges are not required while installing.
Fixes#720.
This is an experimental fix for spellchecker. Previously, we were only using this on macOS since on other platforms, the spellcheck-module claimed to auto-detect + switch language on the fly but looks like it's not working as expected.
Addresses the issue of the webview not being in focus
after the Back button is clicked. Now, the webview is focused
explicitly by calling focus() on click.
* lint: Implement HTML Linting with htmlhint and fix indent.
Implements HTML linting using htmlhint and uses
indentation rules of zulip webapp - 4 spaces.
Creates a separate file .htmlhintrc for the rules, most
of which are defaults. Also, fixes indentation in html
files and adds a missing title in about.html.
* deps: Change versioning of various dependencies to exact versions.
As we prefer to use exact working version
for dependencies, changed the versions to
exact versions.
Fixes#676.
* lint: Implement CSS linting with stylelint.
* lint: Format CSS files according to lintconfig.
Adds CSS linting following the rules of zulip webapp.
Some rules have been ommitted because they required
significant changes in code. Also, creates a separate
.stylelintrc for storing css config.
Fixes CSS part of #676.
Numpad keys by default aren't supported by electron
for using in menu accelarators. Uses a workaround to
make zoom options work with Numpad keys.
Fixes: #344.
This commit works around a couple of bugs, which seem to be upstream bugs in the
current version of Electron.
First, `webContents.isFocused()` seems to be true even if we just switched to
a tab, and are trying to set it as the focused element. To work around this, we
check if the `webview` element is the same as `document.activeElement`.
Also, as per https://github.com/electron/electron/issues/15718, it looks like
`blur` needs to be called on the currently active element, before switching
focus on another element i.e., calling `focus` on it.
Fixes: #634.
This fixes two issues -
a) While on the first server, Ctrl+Shift+Tab doesn't work. This fixes that and now cycles to the last active webview.
b) Disable org cycling for non-server pages likes settings.
Fixes#691.
* Adds a new option to the Window menu that allows users to change to the
next organization cyclically. Activated by Ctrl + Tab.
* Switch to the previous server on Ctrl + Shift + Tab.
In certain requests like for fetching realm icons, request tries to verify server certificate and fails when the user has chosen to ignore cert warnings and has not uploaded the cert.
In those cases, we should mark that this server verification is ignored and ask request to ignore the cert verification bypassing that parameter.
Fixes#684.
Addresses a problem where the context menu would get the incorrect index
of server in sidebar and cause a crash when attempting to remove the
server.
Add comment justifying extra index parameter.
