paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-04 05:53:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,742 Commits 27 Branches 70 Tags
8ec9a98c868af3fe7c41a48ca5edb2bf74b23d67
Commit Graph

734 Commits

Author SHA1 Message Date
Anders Kaseorg
8ec9a98c86 ServerTab: Inline init method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 18:13:30 -07:00
Anders Kaseorg
277d7ef824 FunctionalTab: Inline init method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 18:11:55 -07:00
Anders Kaseorg
cc844e6905 Logger: Remove unused options. 
All of our loggers have timestamp: true.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 14:06:43 -07:00
Anders Kaseorg
b07995c3ed Simplify querySelectorAll(…)[0] to querySelector(…). 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 14:06:43 -07:00
Anders Kaseorg
67228d295d Reformat all code with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:04:00 -07:00
Anders Kaseorg
ce9a680333 Add a tagged template function for HTML supporting HTML interpolation. 
This allows better Prettier integration: Prettier recognizes and
reformats tagged template literals with a tag named ‘html’.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:00:49 -07:00
Anders Kaseorg
6da7cf6b8e Remove Gulp build system. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 17:59:32 -07:00
tarun8718
25d0aefe37 server-tab: Fix upper limit of generated shortcuts 
Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
 2021-03-29 20:23:06 -07:00
Anders Kaseorg
851bb7904f Move modules shared between main and renderer processes to app/common. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:01:52 -07:00
Anders Kaseorg
76d321fa79 xo: Enable @typescript-eslint/consistent-type-imports. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 17:48:54 -07:00
Anders Kaseorg
a9f479d60d Enable worldSafeExecuteJavaScript. 
This has no effect on our use of executeJavaScript, and will become
the default in Electron 12, but for now it silences a warning in
development mode.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:14:00 -08:00
Anders Kaseorg
7b095a683c Replace electron-is-dev with app.isPackaged. 
This unfortunately uses remote, but that’s what electron-is-dev was
doing anyway.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:14:00 -08:00
Anders Kaseorg
12ae84b757 xo: Fix unicorn/prefer-spread. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:13:43 -08:00
Anders Kaseorg
75da0a16c1 xo: Fix unicorn/no-array-for-each. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:13:36 -08:00
Anders Kaseorg
bd0869ec07 preload: Move extra keyboard shortcuts to invisible menu items. 
Fixes #1060.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-16 15:29:25 -08:00
tarun8718
07ae127cc8 shortcuts-section: Deduplicate templateMacHTML and templateWinLinHTML. 
Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
 2021-02-02 10:49:35 -08:00
Anders Kaseorg
a95ee64f7d xo: Use eslint-import-resolver-typescript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:35:02 -08:00
Anders Kaseorg
7d6c6bc10a xo: Fix unicorn/prefer-number-properties. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
18b41938de xo: Fix unicorn/empty-brace-spaces. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
9fe382b27f xo: Fix unicorn/explicit-length-check. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
f022b338e6 xo: Fix unicorn/no-lonely-if. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
855d99dfa0 xo: Fix unicorn/prevent-abbreviations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
cc2424e0bf xo: Fix @typescript-eslint/no-confusing-void-expression. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
2e90e24552 Remove fs-extra dependency. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-17 17:20:32 -08:00
Anders Kaseorg
682511bb68 injected: Remove unused page_params type declaration. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-08 16:40:49 -08:00
Anders Kaseorg
02fbe1a6a1 Revert to upstream undo and redo roles. 
This reverts part of commit 01f6e77237
(#866).  The Electron bug was fixed upstream in Electron 9.0.0-beta.23.

Closes #899.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-02 19:54:22 -08:00
Anders Kaseorg
79808e8ee9 preload: Provide hooks for server to robustly replace logout et al. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 18:11:45 -08:00
Anders Kaseorg
2c38df10c8 electron-bridge: Expose boolean return from emit. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:59:59 -08:00
Anders Kaseorg
1ca15d44a0 electron-bridge: Move mutable state out of electron_bridge. 
Only the initial value of a mutable field is exposed via
exposeInMainWorld, which is why we have a bunch of setter and getter
functions.  It’s better to avoid the possibility for this confusion.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:54:21 -08:00
Anders Kaseorg
82450a91a9 preload: Remove retry button redirection hack. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:18:09 -08:00
Anders Kaseorg
62edfa6f8b Remove macOS notification inline replies feature. 
node-mac-notifier no longer builds on macOS with Electron 11 (error:
no template named 'remove_cv_t' in namespace 'std').  It was
previously implicated in crashes on macOS (#1016).  And we no longer
have any macOS developers that seem to be maintaining this
feature (e.g. #1022 is stalled).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:06:11 -08:00
Anders Kaseorg
df3f719e89 Upgrade dependencies, including Electron 11.0.3. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 16:02:41 -08:00
Anders Kaseorg
0632d8199f injected: Condition narrow-by-topic handler on page_params. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 16:02:32 -08:00
Anders Kaseorg
047bf0ca45 webview: Pass webPreferences values as explicit booleans 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-30 12:39:35 -08:00
Anders Kaseorg
ba432d32b3 Remove preventdrag script. 
This was not a security feature; security is enforced using context
isolation and the same-origin policy.

Furthermore, navigation on drag-and-drop was already disabled by
default in Electron 3.0.

https://www.electronjs.org/blog/electron-3-0#breaking-api-changes

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-17 16:10:47 -08:00
aryanshridhar
cd77fc6448 new-server-form: Strip whitespace from added organization URL. 
Fixes #1037.
 2020-11-15 19:56:53 -08:00
Anders Kaseorg
73710319e6 xo: Fix unicorn/prevent-abbreviations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
da91dc5595 xo: Fix @typescript-eslint/consistent-indexed-object-style. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
31d5e5a092 xo: Fix unicorn/prefer-ternary, I guess. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
13ee1d0990 logger-util: Add missing space. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
d5a9063378 typescript: Fix implicit any in catch clauses. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
918064f35d checkDomain: Remove special handling for “certificate” error strings. 
The fragile check has been broken by changing strings, and the default
invalidZulipServerError message is fine.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:01 -07:00
Anders Kaseorg
193b8326bc injected: Check if narrow is defined. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:32:05 -07:00
Anders Kaseorg
9abb7f376e injected: Remove unused default_language from zulipWindow type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:32:05 -07:00
Aryan Shridhar
126bb26a6e Tray Icon : Changed Unread tray icon in Windows. 
Replaced unread messages icon in the lower tray bar in windows with a new icon.
Fixed #506.
 2020-09-17 16:07:23 +05:30
Anders Kaseorg
23e86abb5b Remove support for custom certificate exceptions. 
Version 5.4.0 and later uses electron.net for all network
requests (#993), so custom certificates can now be configured in the
same system certificate store that Chrome uses.

https://zulip.com/help/custom-certificates#desktop

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-11 22:25:28 -07:00
Anders Kaseorg
97f8fe71af Escape all strings inserted into CSS selectors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:42 -07:00
Anders Kaseorg
a9d59b3dcd CVE-2020-24582: Escape all strings interpolated into HTML. 
Also fix various variable names to consistently indicate which strings
contain HTML.

Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency.  It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:38 -07:00
Anders Kaseorg
c302ebe282 general-section: Convert .filter(…)[0] to .find(…). 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-25 15:40:40 -07:00
Anders Kaseorg
0f1245b975 Upgrade dependencies, including Electron 9. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 01:37:41 -07:00