paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-10-31 12:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,830 Commits 27 Branches 70 Tags
b35d45955ba56c6be01570f7fb95805acaee1052
Commit Graph

105 Commits

Author SHA1 Message Date
Anders Kaseorg
b35d45955b WebView: Move initialization from dom-ready event to did-attach event. 
This fixes the bug where the context menu would disappear immediately
if the page had been loaded an even number of times.

Fixes #662, fixes #991, fixes #1010.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 18:10:43 -07:00
Anders Kaseorg
014e97b563 Remove feedback widget. 
@electron-elements/send-feedback won’t work with Electron 14, and all
it ever did was open your mail client.  Have the “Report an Issue”
menu item direct users to our website instead.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-08-30 19:04:20 -07:00
Anders Kaseorg
fa3c744e76 displayInitialCharLogo: Fix incorrect cast. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-21 13:37:31 -07:00
Anders Kaseorg
e48c9067a3 Upgrade Prettier to 2.3.2. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-05 16:55:47 -07:00
Anders Kaseorg
892f7c8e47 Strongly type config options. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-28 20:29:40 -07:00
Anders Kaseorg
6a3f50d606 Use Partial types for DNDSettings, SettingsOptions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-28 18:00:15 -07:00
Anders Kaseorg
79f9362736 Strongly type IPC messages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 20:44:05 -07:00
Anders Kaseorg
164038ec3c Specialize the renderer-callback event to permission-callback. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 20:39:49 -07:00
Anders Kaseorg
20295ddc50 webview: Use send method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 19:57:38 -07:00
Anders Kaseorg
994c412bd2 renderer: Use ipcRenderer.sendTo to communicate with other WebContents. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 19:57:38 -07:00
Anders Kaseorg
077f3e6e78 eslint: Enable sort-imports for member sorting. 
This sorts the members imported within each individual declaration; we
use import/order for sorting multiple declarations.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-03 15:07:40 -07:00
Anders Kaseorg
9a81ade1c8 typescript: Enable strictNullChecks. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 15:19:42 -07:00
Anders Kaseorg
1e10a3c406 domain-util: Make alias and icon required members of ServerConf. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 15:01:38 -07:00
Anders Kaseorg
eeade47eb6 nav: Add NavItem literal type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 18:45:55 -07:00
Anders Kaseorg
cc844e6905 Logger: Remove unused options. 
All of our loggers have timestamp: true.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 14:06:43 -07:00
Anders Kaseorg
67228d295d Reformat all code with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:04:00 -07:00
Anders Kaseorg
6da7cf6b8e Remove Gulp build system. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 17:59:32 -07:00
Anders Kaseorg
851bb7904f Move modules shared between main and renderer processes to app/common. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:01:52 -07:00
Anders Kaseorg
7b095a683c Replace electron-is-dev with app.isPackaged. 
This unfortunately uses remote, but that’s what electron-is-dev was
doing anyway.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:14:00 -08:00
Anders Kaseorg
75da0a16c1 xo: Fix unicorn/no-array-for-each. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:13:36 -08:00
Anders Kaseorg
18b41938de xo: Fix unicorn/empty-brace-spaces. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
cc2424e0bf xo: Fix @typescript-eslint/no-confusing-void-expression. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
02fbe1a6a1 Revert to upstream undo and redo roles. 
This reverts part of commit 01f6e77237
(#866).  The Electron bug was fixed upstream in Electron 9.0.0-beta.23.

Closes #899.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-02 19:54:22 -08:00
Anders Kaseorg
79808e8ee9 preload: Provide hooks for server to robustly replace logout et al. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 18:11:45 -08:00
Anders Kaseorg
31d5e5a092 xo: Fix unicorn/prefer-ternary, I guess. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
d5a9063378 typescript: Fix implicit any in catch clauses. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
97f8fe71af Escape all strings inserted into CSS selectors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:42 -07:00
Anders Kaseorg
a9d59b3dcd CVE-2020-24582: Escape all strings interpolated into HTML. 
Also fix various variable names to consistently indicate which strings
contain HTML.

Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency.  It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:38 -07:00
Anders Kaseorg
ec205f68a6 Send only needed data from tabs over IPC. 
Fixes exceptions from the structured clone algorithm raised by
Electron 9.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 00:39:38 -07:00
Anders Kaseorg
8d66f05924 xo: Sort imports with import/order. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:06:41 -07:00
Anders Kaseorg
9cf26f4890 dependencies: Upgrade dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:47 -07:00
Anders Kaseorg
397a7381b8 main: Use import() syntax for electron-connect. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:38 -07:00
Anders Kaseorg
9ceabe02d5 Use optional catch binding. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:29 -07:00
Manav Mehta
e97ab2e6dd Replace deprecated getWebContents API 2020-06-30 20:33:41 -07:00
Manav Mehta
0fff6336c7 spellchecker: Use Electron 8 built-in spellchecker. 
* Using electron built-in spellchecker
* Added the custom context menu

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>

Fixes: #504
 2020-06-18 18:14:23 +05:30
Akash Nimare
f976270d33 lint: Fix linting errors. 2020-06-17 01:44:08 +05:30
Akash Nimare
2f70621255 windows: Turn off start at login by default. 
Fixes: #960.
 2020-06-16 20:10:23 +05:30
Anders Kaseorg
5d775405d9 Update zulipchat.com links to zulip.com. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-08 14:01:40 -07:00
Anders Kaseorg
99a3530238 xo: Add arrow-body-style rule 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-26 11:25:24 -07:00
Manav Mehta
f55570f2f5 Handle Reset options gracefully. 
Fixes: #903.
 2020-05-20 21:54:36 +05:30
Anders Kaseorg
d661895545 Remove the insecure ignoreCerts option. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-13 04:06:50 -07:00
Anders Kaseorg
22d7ef5615 main: Turn electron-connect off by default. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-06 16:58:25 -07:00
Anders Kaseorg
983254c310 CVE-2020-12637: Do not ignore certificate errors without ignoreCerts. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-05 12:54:35 -07:00
Anders Kaseorg
b6059077d8 Generalize permission-response mechanism to renderer-callback. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-05 12:54:35 -07:00
Anders Kaseorg
34e2b3a3d0 typescript: Eradicate most any annotations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-04 01:08:05 -07:00
Anders Kaseorg
6b7cce0366 ServerManagerView: Convert loading from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-03 19:16:05 -07:00
Anders Kaseorg
73fec72e6d registerIpcs: Convert webviewListeners to array with functions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-03 19:09:22 -07:00
Manav Mehta
98174fdcaf help: Update Help Center URL. 
Earlier the menu option used to redirect to *.zulipchat.com/help which is already reachable from the webapp.
This will enable the desktop app to redirect only to zulipchat.com/help instead of the help page of the corresponding organization.

Fixes: #948.
 2020-05-02 20:17:25 +05:30
Anders Kaseorg
d9afee3330 ServerManagerView: Convert functionalTabs from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
a46f2ed618 xo: Enable import/no-mutable-exports. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00