paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

i18n: Keep markup out of a translated string where we easily can.

Browse Source 
Use jQuery DOM construction methods, rather than string concatenation,
to keep things structured and to stay clear of the lint rules introduced
in ee6235d71.
This commit is contained in:
Greg Price
2017-09-07 13:00:54 +09:00
parent 99f4d420a5
commit 0986fe700d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/settings_org.js
View File

@@ -108,10 +108,12 @@ exports.populate_auth_methods = function (auth_methods) {
if (!page_params.is_admin) {
$(".organization-box [data-name='auth-methods']")
.find("input, button, select, checked").attr("disabled", true);
var tip_box = $("<div class='tip'></div>")
.text(i18n.t("Only organization administrators can edit these settings."));
// Don't prepend a tip to custom emoji settings page. We handle it separately.
$(".organization-box").find(".settings-section:not(.can-edit)")
.not("#emoji-settings")
.prepend(i18n.t("<div class='tip'>Only organization administrators can edit these settings.</div>"));
.prepend(tip_box);
}
};