paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

user popover: Fix cropping/positioning.

Browse Source 
We use the `fix_positions` options every time
we launch a user popover, whether it is from
the message pane avatar or the buddy list
chevron.

For the message pane case, we can eliminate
some complexity related to trying to put
the menu above or below the avatar.  We now
always suggest "right", and if there are
constraints due to being close to the edge
of the screen, the fix_positions code
will take care of it.
This commit is contained in:
Steve Howell
2019-02-14 15:54:39 +00:00
committed by Tim Abbott
parent 66c6423001
commit 19a434a289
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/popovers.js
View File

@@ -163,6 +163,7 @@ function render_user_info_popover(user, popover_element, is_sender_popover, priv
user_is_guest: user.is_guest}),
trigger: "manual",
top_offset: 100,
fix_positions: true,
});
popover_element.popover("show");
@@ -178,7 +179,6 @@ exports._test_calculate_info_popover_placement = calculate_info_popover_placemen
// message is the message containing it, which should be selected
function show_user_info_popover(element, user, message) {
var last_popover_elem = current_message_info_popover_elem;
var popover_size = 428; // hardcoded pixel height of the popover
popovers.hide_all();
if (last_popover_elem !== undefined
&& last_popover_elem.get()[0] === element) {
@@ -198,7 +198,7 @@ function show_user_info_popover(element, user, message) {
var is_sender_popover = message.sender_id === user.user_id;
render_user_info_popover(user, elt, is_sender_popover, "respond_personal_button",
"message-info-popover", calculate_info_popover_placement(popover_size, elt));
"message-info-popover", "right");
current_message_info_popover_elem = elt;
}