paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

icons: Switch from text-o to code-o for view source / edit topics.

Browse Source 
This commit replaces fa-file-text-o with fa-file-code-o which is a
better signal for the "view source" action. It also deletes a single
line comment that had suggested the change once we moved into font
awesome 4, which Aditya Bansal <adi.bansal241996@gmail.com> helped
out in doing, first via
91962aa6ab and most recently via
75ae94e459 with several commits in
between.
This commit is contained in:
YashRE42
2020-05-21 11:50:49 +05:30
committed by Tim Abbott
parent 1aebf3cab9
commit 669f482b0d
4 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/documentation/user.md
View File

@@ -147,8 +147,8 @@ class="fa fa-cog"></i>) icon`
`down chevron (<i class="fa fa-chevron-down"></i>) icon`
* eye (<i class="fa fa-eye"></i>) icon — `eye (<i
class="fa fa-eye"></i>) icon`
* file (<i class="fa fa-file-text-o"></i>) icon — `file (<i
class="fa fa-file-text-o"></i>) icon`
* file (<i class="fa fa-file-code-o"></i>) icon — `file (<i
class="fa fa-file-code-o"></i>) icon`
* filled star (<i class="fa fa-star"></i>) icon —
`filled star (<i class="fa fa-star"></i>) icon`
* formatting (<i class="fa fa-font"></i>) icon —

2
static/js/ui_init.js
View File

@@ -41,7 +41,7 @@ function message_hover(message_row) {
!message.status_message) {
message_row.find(".edit_content").html('<i class="fa fa-pencil edit_content_button" aria-hidden="true" title="Edit (e)"></i>');
} else {
message_row.find(".edit_content").html('<i class="fa fa-file-text-o edit_content_button" aria-hidden="true" title="View source (e)" data-message-id="' + id + '"></i>');
message_row.find(".edit_content").html('<i class="fa fa-file-code-o edit_content_button" aria-hidden="true" title="View source (e)" data-message-id="' + id + '"></i>');
}
}

3
static/templates/actions_popover_content.hbs
View File

@@ -3,8 +3,7 @@
{{#if should_display_edit_and_view_source}}
<li>
<a href="#" class="popover_edit_message" data-message-id="{{message_id}}">
{{! Can consider https://fontawesome.com/v4.7.0/icon/file-code-o when we upgrade to font awesome 4.}}
<i class="{{#if use_edit_icon}}fa fa-pencil{{else}}fa fa-file-text-o{{/if}}" aria-hidden="true"></i> {{editability_menu_item}}
<i class="{{#if use_edit_icon}}fa fa-pencil{{else}}fa fa-file-code-o{{/if}}" aria-hidden="true"></i> {{editability_menu_item}}
</a>
</li>
{{/if}}

2
templates/zerver/help/edit-or-delete-a-message.md
View File

@@ -31,7 +31,7 @@ content.
[disabled by an organization administrator](/help/disable-message-edit-history).
If you don't see the pencil (<i class="fa fa-pencil"></i>) icon, the message content
can no longer be edited. You should see a file (<i class="fa fa-file-text-o"></i>)
can no longer be edited. You should see a file (<i class="fa fa-file-code-o"></i>)
icon instead. Clicking the file icon will allow you to view the
[Markdown source](/help/view-the-markdown-source-of-a-message) of the message, or
[edit the topic](/help/change-the-topic-of-a-message).