This commit updates the topic URL in the message header topic menu
popover, introduced in feedb6ea2d to a
permalink having a `with` operator attached to it.
This commit documents the `/remotes/push/e2ee/register` endpoint.
We use auth_email="ZULIP_ORG_ID" and auth_api_key="ZULIP_ORG_KEY"
instead of "BOT_EMAIL_ADDRESS" and "BOT_API_KEY".
Until now we were not documenting bouncer's REST API endpoints.
We plan to document the newly introduced "remotes/push/e2ee/register"
and "remotes/push/e2ee/notify" endpoints.
This commit does the prep work for documenting bouncer endpoints:
* mark the older endpoints related to sending non-E2EE push
notifications as "intentionally_undocumented" - we'll remove
them in future.
* the remaining endpoints are marked pending-to-document with
helpful comments.
The 'function' variable in 'APICodeExamplesPreprocessor.generate_text'
matches the pattern of API_ENDPOINT_NAME = r"/[a-z_\-/-{}]+:[a-z]+"
It is always of the form 'endpoint_path:endpoint_method'.
There's no possibility of multiple ':'.
This commit removes the unused code block in `render_curl_example`,
which was trying to get 'auth_email' & 'auth_api_key' from 'function'.
Adds a log for the end-to-end latency from when the worker decided
to send push notifications & received a success response from bouncer.
Fixes part of #35368.
Expands the mobile tab for "Browse and subscribe to channels" to
include information about subscribing to a channel via a link and
the long-press channel menu.
@types/mdast was in dev dependencies while it shouldn't have been, we
move that away from dev dependencies and bump the version. We need the
package when running the astro build step.
Similar to drafts, identify when a scheduled message will be sent to
the logged-in user. This allows the UI to show 'You' as the header for
self-scheduled messages, improving the user experience.
When using direct message groups as the preferred method for 1:1 or
self-messages, the get_recipient_ids function should include the
user ID for self-messages. Without this, the UI cannot detect who
was the recipient of the message.
Adding "text-align: start" css to banner-label element makes
sure that the banner text is not aligned as per the alignment
of parent element, as we require left alignment of text for
all the banners. Only navbar banners have text align in center
but that is handled by adjusting the flex layout of the
banner-content, parent of banner-label, element.
We use the same "v" key for opening and closing the
lightbox overlay.
We already have code to open and close the lightbox
overlay in hotkey.ts.
Having another keydown handler for closing the overlay
resulted in a bug where the overlay was just not being
opened because the second handler was immediately called
to close the overlay was immediately called after the first.
Fixes#35868.
The same subscription request can contain both existing channels
and newly created channels, so we clarify here that direct message
notifications are only sent when users are subscribed to existing
channels.
Also, updates this text to use "direct message" instead of "DM".
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
For the sake of completion, we add a test case ensuring that
the response does not contain `new_subscription_messages_sent` if
the parameter `send_new_subscription_messages` is `false`,
as mentioned in the API documentation.
When the number of new subscriptions crosses a threshold, we wish to
avoid sending DMs to the user as implemented in #31206. But there was
a bug causing announcement channel and new channel notification
messages to also not be sent.
This commit fixes that bug by ensuring that we only exclude direct
message notications.
In #31206, we changed `add_subscriptions_backend` to exclude the
notification bot DMs when subscribing users to a channel when the
number of subscriptions exceeds MAX_BULK_NEW_SUBSCRIPTION_MESSAGES.
This caused a bug where new channel announcement and creation
notification messages were not being sent. Here we add a test that
confirmes the current behavior, which will be corrected in a
subsequent commit.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
