Fixes#35326.
Previously, the visibility of unread counts for both the home view and
the "CHANNELS" heading was controlled by the "Hide unread summary counts"
setting. Now, it controls only the visibility of unread counts in the
home view.
Now the former is only used in the channels list (headers and inactive
toggles included) and the latter is only used for the home view.
Note that this changes some behavior, notably the header and inactive
toggles now show the masked dots when all unread markers in them are
also masked.
When navigating user to a `near` narrow if
`first_unread_msg_id_pending_server_verification`,
we didn't remove the `with` term, which results in
`is_conversation_view_with_near` check failing and hence
results in unexpected behaviour.
Once the help center has transitioned to astro, we will look at
adding back the formatting to the title and sidebar for these
two articles: "General chat topic" and "General chat channels".
Our current conversion script does not work well with inserting
flattened steps in indented lists. Adding support for indented lists
would be non-trivial. Flattened steps are inserted either in case of
files or relative/setting links. I used this ( +)\{ regex to test for
instances where we might need to insert Flattened steps in an indented
block. Turns out saml-login-button.md is the only includes that faces
the issue only in saml-authentication.md.
There was no strong reason for these sub-lists to be ordered lists and
we decided to turn it into unordered list. Discussion at
https://chat.zulip.org/#narrow/channel/19-documentation/topic/new.20help.20center.3A.20numbering.20regression/near/2232242
The expected behaviour would be to have some spaces from the second line
onwards for multi-list items. Regex used to check for this was
`^1\..*\r?\n^[^\s].*$` which gives us some extra results that don't fit
our criteria which we can chose to ignore.
FlattenList was not able to handle other components inside a list in the
past, but that has changed in the past few commits and we no longer need
to check for tips in include files for `is_include_only_ordered_list`.
We had some include files that started with another include, and in some
cases this nested included file was also `only` an ordered list. In that
case, we need to add a flattenlist around the file, but our current
conversion script was not accounting for that.
The indentation in the original files was fine for the current help
center, but when converting the files to MDX, the indentation made the
includes and the code blocks look like they were on the same level as
the list item and not part of it.
I did a manual check of code blocks with indentation in help/ and how
they looked when converted to the new help center and the rest of the
cases looked fine.
For included files, our conversion tool needs a file just to be an
ordered list to properly surround it with FlattenList. If there is
heading and description in the file, the conversion script will not
insert FlattenList. So, we just create two different include files in
this case, first for the heading/description and second for the ordered
list.
In the commits following this, we are going to make changes which will
introduce cases with paragraphs, code blocks and other elements inside
list items. Right now, FlattenList will just break in those cases. We
need to return those elements without flattening since those are valid
elements inside a list item.
"Hide" is a better verb with the channel folders UI.
Also automatically hide inactive channels at 20+ susbscribed channels,
as we have more content in the left sidebar now.
This commit adds "max_channel_folder_name" and
"max_channel_folder_description" fields to response.
Also updated webapp to use these fields instead of hardcoding
the values.
This needs explanation both in upgrade notes and in the main
documentation for mobile push notifications.
Co-authored-by: Prakhar Pratyush <prakhar@zulip.com>
This commit replaces the `PUSH_NOTIFICATION_REDACT_CONTENT` server
setting with `require_e2ee_push_notifications` realm setting.
If `require_e2ee_push_notifications` set to True:
* Older clients: Content redacted
* Updated clients: Encrypted content
If `require_e2ee_push_notifications` set to False:
* Older clients: Content NOT redacted
* Updated clients: Encrypted content
Note: Older clients refers to clients that don't support E2EE.
Fixes part of #35370.
